Skip to content

[RORDEV-2229] Cap the spacesPlugin wait at Kibana 9.5.3 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coutoPL merged 2 commits into from
Sep 17, 2026
Merged

[RORDEV-2229] Cap the spacesPlugin wait at Kibana 9.5.3 #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c06ba50
Cap the spacesPlugin wait at Kibana 9.5.3
coutoPL Sep 17, 2026
9845e77
versions bump
coutoPL Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/all-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:
env:
APPLY_RESOURCE_LIMITS: "auto"
# Newest first: a failure on the newest line is the one to see first in the run UI.
ELK_VERSIONS: "9.5.3 9.4.6 8.19.21 7.17.29"
ELK_VERSIONS: "9.5.4 9.4.7 8.19.21 7.17.29"
ECK_3X: eck-3.5.0
ECK_2X: eck-2.16.1

Expand Down
8 changes: 6 additions & 2 deletions e2e-tests/cypress/support/page-objects/RoAndRoStrictKibanaAccessAssertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,15 @@ export class RoAndRoStrictKibanaAccessAssertions {
}

private static changeTenancyAndAwaitSpaces(tenancyName: string) {
if (semver.gte(getKibanaVersion(), '9.4.0')) {
const shouldAwaitSpacesPlugin = semver.gte(getKibanaVersion(), '9.4.0') && semver.lte(getKibanaVersion(), '9.5.3');

if (shouldAwaitSpacesPlugin) {
cy.intercept('*/bundles/plugin/spaces/1.0.0/spaces.chunk*').as('spacesPlugin');
}

RorMenu.changeTenancy(tenancyName);
if (semver.gte(getKibanaVersion(), '9.4.0')) {

if (shouldAwaitSpacesPlugin) {
cy.wait('@spacesPlugin');
}
}
Expand Down
Loading