Skip to content

Expect the /exports reporting URL on Kibana 9.1+ - #140

Open
sscarduzio wants to merge 1 commit into
masterfrom
fix/reporting-exports-redirect-9.1
Open

sscarduzio wants to merge 1 commit into
masterfrom
fix/reporting-exports-redirect-9.1

Conversation

@sscarduzio

@sscarduzio sscarduzio commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Problem

Sanity-check.cy.ts expects the bare /reporting URL after the tenancy change on Kibana 9.x. Kibana 9.1 and later redirect that page to /reporting/exports (<Redirect from="/" to="/exports" /> in mount_management_section.tsx on branches 9.1 and 9.5; absent on 9.0). The check passed only when Cypress read the URL before the client-side redirect fired. When the redirect won, changeTenancy timed out after 20 s on all three retries. Last seen on e2e_es94x with ELK 9.5.4 in the ES plugin pipeline.

Fix

Expect /reporting/exports on >=8.19.0 <9.0.0 || >=9.1.0 in Sanity-check.cy.ts and Reporting.verifyIfReportingPageAfterRefresh. Same range Dev-tools.cy.ts already uses.

Targets master: a fix for a test that fails against the released plugins. Merge master back into develop after this lands; the ES plugin pipeline clones develop.

Same change in readonlyrest_kbn/automatic-tests: sscarduzio/readonlyrest_kbn PR (linked in a comment).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated reporting navigation for Kibana 9.1 and later to correctly redirect to the Exports page.
    • Preserved direct reporting-page navigation for Kibana 9.0 and other versions outside the supported redirect ranges.
  • Tests
    • Updated automated checks to validate reporting-page redirects across supported Kibana versions.

Kibana 9.1 and later redirect the reporting management page to /exports, the same as 8.19. The
sanity check expected the bare /reporting path there and passed only when Cypress read the URL
before the client-side redirect fired.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sscarduzio

Copy link
Copy Markdown
Contributor Author

Same change in readonlyrest_kbn: https://github.com/sscarduzio/readonlyrest_kbn/pull/1057

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d8ae91db-7bf2-4a0e-b1f3-6eb25407373c

📥 Commits

Reviewing files that changed from the base of the PR and between 6110d57 and 0bc802f.

📒 Files selected for processing (2)
  • e2e-tests/cypress/e2e/Sanity-check.cy.ts
  • e2e-tests/cypress/support/page-objects/Reporting.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The reporting tests now expect the /exports redirect for Kibana versions 9.1 and later. Kibana 9.0.x continues to use the bare reporting path. Both redirect computation and URL verification use the expanded range.

Changes

Reporting redirect handling

Layer / File(s) Summary
Extend reporting redirect version range
e2e-tests/cypress/e2e/Sanity-check.cy.ts, e2e-tests/cypress/support/page-objects/Reporting.ts
The redirect target and refresh verification now treat Kibana >=8.19.0 <9.0.0 or >=9.1.0 as using /exports. Kibana 9.0.x retains the bare reporting path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: dzuming

Merge Risk: ⚪ Minimal · up to 0bc80

The tests now expect Kibana 9.1+ to redirect reporting to /exports while preserving the existing path for 9.0.x; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating reporting URL expectations for Kibana 9.1 and later.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sscarduzio
sscarduzio requested a review from coutoPL September 22, 2026 14:11
@coutoPL
coutoPL requested a review from Dzuming September 22, 2026 15:58

@Dzuming Dzuming left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants