Expect the /exports reporting URL on Kibana 9.1+ - #140
sscarduzio wants to merge 1 commit into
Conversation
Kibana 9.1 and later redirect the reporting management page to /exports, the same as 8.19. The sanity check expected the bare /reporting path there and passed only when Cypress read the URL before the client-side redirect fired. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Same change in readonlyrest_kbn: https://github.com/sscarduzio/readonlyrest_kbn/pull/1057 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe reporting tests now expect the ChangesReporting redirect handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The tests now expect Kibana 9.1+ to redirect reporting to /exports while preserving the existing path for 9.0.x; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Sanity-check.cy.tsexpects the bare/reportingURL after the tenancy change on Kibana 9.x. Kibana 9.1 and later redirect that page to/reporting/exports(<Redirect from="/" to="/exports" />inmount_management_section.tsxon branches 9.1 and 9.5; absent on 9.0). The check passed only when Cypress read the URL before the client-side redirect fired. When the redirect won,changeTenancytimed out after 20 s on all three retries. Last seen one2e_es94xwith ELK 9.5.4 in the ES plugin pipeline.Fix
Expect
/reporting/exportson>=8.19.0 <9.0.0 || >=9.1.0inSanity-check.cy.tsandReporting.verifyIfReportingPageAfterRefresh. Same rangeDev-tools.cy.tsalready uses.Targets
master: a fix for a test that fails against the released plugins. Mergemasterback intodevelopafter this lands; the ES plugin pipeline clonesdevelop.Same change in
readonlyrest_kbn/automatic-tests: sscarduzio/readonlyrest_kbn PR (linked in a comment).🤖 Generated with Claude Code
Summary by CodeRabbit