Another text measurement fix#24669
Open
ickshonpe wants to merge 3 commits into
Open
Conversation
…he content box but the node is sized as though the text isn't wrapped. Fixed by subtracting the total inset to get the content size for measurement.
Zeophlite
approved these changes
Jun 19, 2026
kfc35
approved these changes
Jun 20, 2026
kfc35
added
C-Bug
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
dloukadakis
suggested changes
Jun 20, 2026
dloukadakis
added
M-Deliberate-Rendering-Change
Co-authored-by: Dimitrios Loukadakis <dloukadakis@users.noreply.github.com>
ickshonpe
added
S-Ready-For-Final-Review
dloukadakis
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Text is wrapped to fit inside the node's content box but the node is sized as though the text isn't wrapped.
Fixes #24664
Solution
Subtract the total of the horizontal padding and border insets.
Testing
Added the replication from #24664 to
testbed_ui'sTextWrapscene:The other examples, particularly
text_debug, shouldn't demonstrate any changes.