Number input can emit empty value changes#24673
Open
perry-blueberry wants to merge 2 commits into
Open
Conversation
Also changed the example to have the scalar be optional.
kfc35
reviewed
Jun 20, 2026
| commands: &mut Commands, | ||
| number_type_str: &str, | ||
| ) { | ||
| if allow_empty && text_value.is_empty() { |
Contributor
There was a problem hiding this comment.
I think I would move the logic of
if !allow_empty && text_value.is_empty() {
return;
}
from emit_value_change into this function block
Otherwise, it appears that this case isn’t explicitly handled in this fn as is. The else block doesn’t appear to handle that case correctly (since it’s assuming the logic happened outside the function), so it can cause a moment of confusion.
Contributor
|
I don't think this is the right answer. A better approach might be to add a dedicated "error" event. This gets into the whole topic of field validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently there's no event that emits a number input has changed to the empty value. You can do
On<ValueChange<f32>>but you cannot doOn<ValueChange<Option<f32>>>. This adds that possibility with theemit_value_change_on_emptyprop added. This is set tofalseby default so the previous behavior will be used by default.Solution
Adds
emit_value_change_on_emptytoFeathersNumberInputPropsto change the event to emitOn<ValueChange<Option<T>>>. AddEmptytoNumberInputValueto be able to set the value back.I'm not 100% sure how
template_valueworks but I hope I did that part correctly.Testing
I've updated the feathers_gallery example to have the scalar value be able to be empty.
Showcase
Click to view showcase