Add iOS scaffold option#30
Open
Unknownamae wants to merge 1 commit into
Open
Conversation
Author
|
Small scaffold hardening update: the iOS scaffold repo now includes the generated Browserify bundle and package-lock, fixes the BITBOX import path to match the published npm package, and passes a full iOS simulator Debug build with xcodebuild. Commit: Unknownamae/bitbox-scaffold-ios@72b4283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iosto thebitbox new --scaffoldoption description.--scaffold iosto https://github.com/Unknownamae/bitbox-scaffold-ios.git.Hello BITBOXwith a generated 128-bit mnemonic usingbitbox-cli/lib/bitbox-cli.Fixes #13.
Scaffold repo
https://github.com/Unknownamae/bitbox-scaffold-ios
Verification
node -c index.jsnode -c BitboxScaffoldIOS/www/app.jsnpm installnpm run build:webplutil -lint BitboxScaffoldIOS/Info.plistxcodebuild -list -project BitboxScaffoldIOS.xcodeprojlists theBitboxScaffoldIOStarget and scheme.xcodebuild -project BitboxScaffoldIOS.xcodeproj -scheme BitboxScaffoldIOS -configuration Debug -sdk iphonesimulator -derivedDataPath /tmp/BitboxScaffoldIOSDerivedData buildsucceeds.Bounty
This is for the $100 BCH bounty in #13.
Payment details:
1NtNxkDuVNcmZhUXAwtm6ZrXvNNB1AqZFp3DcAQScPshdPCCPRXFjKUjyPFXHpWWpmWpHaCY1XatuyPB5Nrp95pGcRPjdm9SRVr4SEzLQeNZ5h4Tyacinemeskpro@gmail.com