Feature/incidence - #97
Open
rogerssam wants to merge 16 commits into
Open
Conversation
Contributor
Author
|
This branch is superseded by functions that already exist, though they're perhaps not as user friendly. |
build_design_matrix() and the calculate_adjacency_score() / objective_function_piepho() refactors are a separate concern, and the version carried here was missing the piepho write-back fix, which made it a regression rather than a fix. That work now lives on bugfix/grid-orientation, rewritten with coordinate validation and a duplicate-coordinate guard. R/design_utils.R, R/calculate_adjacency_score.R and R/metrics.R are restored to main's versions so this branch merges cleanly once that one lands. R/incidence.R still calls build_design_matrix(), so the branch does not load until then - the intended sequencing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds incidence calculation functions to give details of how often treatments appear in rows or columns (
calculate_position_indidence()) or next to other treatments (calculate_pair_incidence()).Fixes #81
Also possibly addressed in #91