fix: lint generated grammar by default#2
Open
sit-d wants to merge 1 commit into
Open
Conversation
Author
|
Added fresh ad-hoc verification after the final code change:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/lint_grammar.pyso its no-argument default lints the generated grammar indist/fasmg.tmLanguage.jsonscripts/gen_all.py --lintVerification
python3 -m py_compile scripts/*.pypython3 scripts/lint_grammar.py→lint: all 46 regex patterns OK in fasmg.tmLanguage.jsonpython3 scripts/gen_all.py --lint→ generated both dist outputs and reportedlint: all 46 regex patterns OK in fasmg.tmLanguage.jsongit diff --checkNotes / Limitations
scripts/gen_all.py --lintrewrote generated dist files in the working tree during verification; those generated-output changes were reverted because the only intended fix here is the linter default path, and the existing open docs PR already touches the generated UDL drift.scripts/validate.pyfixture assembly was not run because this Linux cron environment does not havefasmginstalled.