define ARRAY_SIZE in one place

[realPJL]

Fixes #1776

[realPJL]

I tried the "Create PR" from inside vs code but ig that leaves out the description.

I added utils.h which now includes the #define ARRAY_SIZE and is being included by display.c and device_config.c. I also checked for other implementations of ARRAY_SIZE but haven't found any.

[mutatrum]

There's a build failure, not sure why. Maybe because the filename shadows utils.h in components/asic?

[realPJL]

The simplest solution that comes to mind would be to just rename utils.h to something different (?)

[realPJL]

The other utils.h is inside components/stratum/include/utils.h.

[mutatrum]

Yeah, or just put it in the existing utils.h, that's being included everywhere already.

[realPJL]

device_config.c and display.c do not (yet) include the existing utils.h.
I'd suggest renaming my utils.h to array.h and keeping it in the root directory. That way we can simply add to it if we need more array functions

[realPJL]

device_config.c and display.c do not (yet) include the existing utils.h. I'd suggest renaming my utils.h to array.h and keeping it in the root directory. That way we can simply add to it if we need more array functions

Should I implement it that way @mutatrum ?

[mutatrum]

Should I implement it that way @mutatrum ?

Go ahead, please.

[realPJL]

Done. Also confirmed the build with idf.py build.

[github-actions]

Test Results

  2 files  ±0    2 suites  ±0   1s ⏱️ ±0s
124 tests ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 
126 runs  ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 129d816. ± Comparison against base commit ca89fdb.

[0xf0xx0]

ack