fix(webui): allow WebUI access via IPv6 addresses - #1908
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
is_network_allowed only understood IPv4-mapped peers and IPv4 Origin hosts, so browsing http://[device-ipv6] loaded static assets but API calls were rejected. Parse bracketed IPv6 Origin hosts, classify ULA/link-local/loopback peers, and allow Origin that matches the device's own IPv4/IPv6 (including GUA from SLAAC). Also bracket IPv6 literals in AxeOS swarm HTTP URLs so client-side requests remain valid when the UI is opened over IPv6. Fixes bitaxeorg#1841 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WebUI access when browsing the miner over IPv6 (
http://[device-ipv6]/). The HTTP server accepted the TCP connection and served static assets, but API/WebSocket handlers rejected requests becauseis_network_allowed()only understood IPv4-mapped peers and IPv4 Origin hosts.Changes
Firmware (
http_server.c)Originheader (previously split on the first:as a port).localallow pathsAxeOS swarm UI
http://URLs so client requests remain valid under IPv6Notes
Test plan
http://[device-ipv6]/— dashboard loads and/api/system/inforeturns 200Fixes #1841