This move is chaotic good#1000
Open
thunderbiscuit wants to merge 1 commit into
Open
Conversation
reez
reviewed
May 12, 2026
reez
left a comment
reez
left a comment
Collaborator
There was a problem hiding this comment.
Good rename, but there are still local path references to the old directory names (CI is failing because workflows still use paths like bdk-ffi, bdk-android, and bdk-swift as working directories / cd targets)
There might be some other ones too I haven't caught yet like workflows, CODEOWNERS, build scripts, and docs? Obv some names should probably stay as package/repo names, but local filesystem paths would to move to rust, kotlin, and swift etc
thunderbiscuit
force-pushed
the
rename
branch
4 times, most recently
from
90f3a3b to
de9aaf9
Compare
Member
Author
|
If we agree this is a good idea, I propose we merge right after the 3.1 release, to give plenty of time for all downstream users to update their build workflows and CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.