Skip to content

feat: expose wallet signing with provided signers#1043

Draft
reez wants to merge 7 commits into
bitcoindevkit:masterfrom
reez:signers2
Draft

feat: expose wallet signing with provided signers#1043
reez wants to merge 7 commits into
bitcoindevkit:masterfrom
reez:signers2

Conversation

@reez

@reez reez commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

#1030 first

Description

Adds wrapper for bdk_wallet::Wallet::sign_with_signers, allowing bindings consumers to sign a PSBT with explicit SignersContainer values instead of only the wallet-owned signers.

This also adds a SignersContainer wrapper that can be constructed from descriptor key material and passed into the new wallet signing method.

Notes to the reviewers

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title feat: expose wallet signing with caller-provided signers feat: expose wallet signing with provided signers Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant