Skip to content

Ethereum Stop Sequence#4161

Open
MicahMaphet wants to merge 3 commits into
bitpay:masterfrom
MicahMaphet:eth-stop
Open

Ethereum Stop Sequence#4161
MicahMaphet wants to merge 3 commits into
bitpay:masterfrom
MicahMaphet:eth-stop

Conversation

@MicahMaphet
Copy link
Copy Markdown
Contributor

@MicahMaphet MicahMaphet commented May 8, 2026

🛑 Description

Previously when using ethereum on bitcore-node, the server would never stop. This was caused by the ethereum rpcs not stopping. This solves this by tearing down rpcs after the worker stops all the services

🪵 Changelog

  • Tear down rpcs after the worker stops the services in all, api, and p2p

🧪 Testing Notes

Tested with a bitcore.config.json that only uses ethereum.
Run, and stop on master and eth-stop:

$ npm run p2p
[press ^C after ETH:regtest up to date message]
info :: 2026-05-08T06:27:30.011Z :: ETH:regtest up to date.
^Cinfo :: 2026-05-08T06:27:33.530Z :: Shutting down P2P pid 55016

Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

Comment thread packages/bitcore-node/src/providers/chain-state/evm/p2p/p2p.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants