Coverage in CI Pipeline#4168
Draft
MicahMaphet wants to merge 8 commits into
Draft
Conversation
…ircle ci tests 3) raised timeout for bitcore-cli coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 🧪
Added coverage with minimum thresholds to the Circle CI tests. Now, if a test doesn't run a certain amount of code, the test will fail in Circle CI. Each test for each package has a threshold for, statements, branches, functions and lines of code. I determined the thresholds by rounding down from what they are currently at. The goal is to prevent coverage from regressing.
Changelog 🪵
bitcore/package.jsonso they can be run in CircleCI + cleanup (removed a lot of commands). @kajoseph Make sure I didn't remove anything needed and let me know if I should remove more.bitcore/package.jsoncoverage scripts instead of test scripts in.circleci/config.yml+ cleanupnpm run coveragein saybitcore-wallet-serviceand the statement coverage is 68, round to 60, branches coverage is 53, rond to 50 etc.bitcore-build, which adds coverage to all JavaScript packages exceptbitcore-tssbitcore-loggingto CircleCI with new coverage checkbitcore-tssinnycconfigNEWbitcore-cliNEWtests as nyc slowed it down causing the create command test to overruntsxfrom everything butbitcore-clientbecause otherwise it breaksTesting Notes 📺
Run all of the coverage tests:
Checklist
crypto-rpcnycfor all packagesnycinbitcore/node_modulesProposal
Don't distinguish between
coverageandtest. Just have all our tests check coverage.