Skip to content

Agalles/create deploy workflow trigger#7093

Open
AmyLGalles wants to merge 3 commits into
mainfrom
agalles/create-deploy-workflow-trigger
Open

Agalles/create deploy workflow trigger#7093
AmyLGalles wants to merge 3 commits into
mainfrom
agalles/create-deploy-workflow-trigger

Conversation

@AmyLGalles

@AmyLGalles AmyLGalles commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

Creating a workflow trigger for deploy release github workflow
https://github.com/bitwarden/deploy/pull/211

📔 Objective

📸 Screenshots

@AmyLGalles AmyLGalles added ai-review Request a Claude code review hold do not merge yet labels Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the conversion of .github/workflows/github-release.yml from a self-contained release job into a thin trigger that delegates to the bitwarden/deploy repo via bitwarden/gh-actions/trigger-actions@main. The previously flagged stray }} corruption on release_ticket_id has been fixed. The removed create-release job, its outputs, and the ARTIFACTS_PATH env var are not referenced by any other workflow, so the change is self-contained. The permissions reduction (dropping contents: write, keeping only id-token: write) is appropriate now that release creation happens in the deploy repo.

Code Review Details

No blocking findings.

Note: this PR carries the hold label and a maintainer comment indicating it should not merge until bitwarden/deploy#211 is merged. The @main pin on bitwarden/gh-actions/trigger-actions matches the existing convention used by the other publish workflows in this repo, so it was not flagged.

Comment thread .github/workflows/github-release.yml Outdated
@AmyLGalles AmyLGalles marked this pull request as ready for review June 23, 2026 19:57
@AmyLGalles AmyLGalles requested a review from a team as a code owner June 23, 2026 19:57
@AmyLGalles

Copy link
Copy Markdown
Contributor Author

don't merge 'til https://github.com/bitwarden/deploy/pull/211 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review hold do not merge yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant