You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed the conversion of .github/workflows/github-release.yml from a self-contained release job into a thin trigger that delegates to the bitwarden/deploy repo via bitwarden/gh-actions/trigger-actions@main. The previously flagged stray }} corruption on release_ticket_id has been fixed. The removed create-release job, its outputs, and the ARTIFACTS_PATH env var are not referenced by any other workflow, so the change is self-contained. The permissions reduction (dropping contents: write, keeping only id-token: write) is appropriate now that release creation happens in the deploy repo.
Code Review Details
No blocking findings.
Note: this PR carries the hold label and a maintainer comment indicating it should not merge until bitwarden/deploy#211 is merged. The @main pin on bitwarden/gh-actions/trigger-actions matches the existing convention used by the other publish workflows in this repo, so it was not flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai-reviewRequest a Claude code reviewholddo not merge yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Creating a workflow trigger for deploy release github workflow
https://github.com/bitwarden/deploy/pull/211
📔 Objective
📸 Screenshots