Add swift-node native addon support - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
swift-node0.1.0 loader support so its target-qualified native addons and runtime sidecars are emitted with valid runtime paths.What This PR Does
swift-node0.1.0's generatedresolveAddonPath()loader.soand.dllsidecar filenames beside the hashed addonWhat This Improves
swift-nodepackages, includingmacos-native-clone-fileWhat This Does Not Do
Important Context
Code To Review Closely
src/index.ts:328Verify that sidecars are emitted only for a resolved
swift-nodeaddon and retain the filenames required by the dynamic linker.Gotchas, Risks, And Edge Cases
swift-node0.1.0Tests And Regression Coverage
Validation Run
pnpm test: 200 passing testspnpm lint: formatting, lint, and type checks passedpnpm build: ESM and CommonJS package builds passedCoverage Assessment
Sufficient for generated-loader bundling because the tests cover the
0.1.0resolver, emitted hashed addon, and Linux/Windows sidecar assets.Regressions These Tests Should Catch
resolveAddonPath()calls fromswift-node0.1.0Gaps And Recommended Follow-Up Tests
Follow-Up Work