Add explicit angles dependency - #22
Open
Plumezz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Guanxiao Qi <944843236@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
anglesas an explicit dependency ofvector_pursuit_controller.src/vector_pursuit_controller.cppdirectly includesangles/angles.hand uses APIs includingangles::normalize_angleandangles::normalize_angle_positivein the controller implementation.Currently,
anglesappears to be available transitively through Navigation2 dependencies such asnav2_controllerornav2_costmap_2d. This change makes the package manifest and CMake configuration match the direct source usage.Changes:
<depend>angles</depend>topackage.xml.find_package(angles REQUIRED)toCMakeLists.txt.anglesto the target/export dependency list.