Conversation
Bumps blasthttp from 0.8.0 to 0.9.0. --- updated-dependencies: - dependency-name: blasthttp dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 9.0.3 to 9.1.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@9.0.3...9.1.0) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.1.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lasthttp-0.9.0 build(deps): bump blasthttp from 0.8.0 to 0.9.0
…ytest-9.1.0 build(deps-dev): bump pytest from 9.0.3 to 9.1.0
Bumps [pytest](https://github.com/pytest-dev/pytest) from 9.1.0 to 9.1.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@9.1.0...9.1.1) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.1.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cryptography](https://github.com/pyca/cryptography) from 48.0.0 to 48.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@48.0.0...48.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-version: 48.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ytest-9.1.1 build(deps-dev): bump pytest from 9.1.0 to 9.1.1
…ography-48.0.1 build(deps): bump cryptography from 48.0.0 to 48.0.1
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 30 30
Lines 3102 3102
=======================================
Hits 3085 3085
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The identify_regex matched any two colon-separated alphanumeric segments with no minimum length, producing IdentifyOnly false positives on short values like abc:def, JSESSIONID:abcdef1234, and government app tokens (0000Qs-hTQlwlgXAYBlmgEFoQTR:1ffkg4vkm). Real django.core.signing output is always payload[:timestamp]:signature where the signature is a base64url HMAC of at least 27 chars (SHA-1, 27) or 43 chars (SHA-256, the default since Django 3.1). Anchor the regex to that structure: optional leading dot, base64url payload, optional 4-8 char base62 timestamp, and a 27+ char signature. Verified against real cookies from both Signer/TimestampSigner and SHA-1/ SHA-256 algorithms; all match, while the false positives are rejected.
The publish job only compared major.minor between the current version and the latest tag, so patch-level bumps (e.g. 1.2.0 -> 1.2.1) were treated as "no change" and never built/published/tagged. Compare the full version string instead, matching the fix already applied in baddns.
release: bump version to 1.2.1 and publish on patch-level changes
…okie-identify-fp fix: tighten Django signed cookie identify_regex to cut false positives
ausmaster
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.2.1 Release
Rolls up the changes accumulated on
devfor the 1.2.1 patch release.Bug fixes
Django signed cookie
identify_regexfalse positives (#427)The
DjangoSignedCookiesidentify regex matched any two colon-separated alphanumeric segments with no minimum length, producingIdentifyOnlyfalse positives on short values likeabc:def,JSESSIONID:abcdef1234, and tokens such as0000Qs-hTQlwlgXAYBlmgEFoQTR:1ffkg4vkm.It now anchors to the real
django.core.signingstructure — optional leading dot, base64url payload, optional 4–8 char base62 timestamp, and a 27+ char base64url HMAC signature:The
{27,}minimum covers both legacy SHA-1 (27 char) and default SHA-256 (43 char) signatures, so all realSigner/TimestampSigner/dumpsoutputs still match while the short false positives are rejected. Addstest_django_identify_false_positives.CI / release
Publish on patch-level version changes (#428)
The
publishjob compared onlymajor.minorof the current version against the latest tag, so patch bumps like1.2.0 → 1.2.1were treated as "no change" and never built, published, or tagged. It now compares the full version string (matching the fix already in baddns), and the tag step is renamed to "Tag the release if version changed".Version bump to
1.2.1.Dependencies
blasthttp0.8.0 → 0.9.0 (build(deps): bump blasthttp from 0.8.0 to 0.9.0 #422)cryptography48.0.0 → 48.0.1 (build(deps): bump cryptography from 48.0.0 to 48.0.1 #425)pytest(dev) 9.0.3 → 9.1.1 (build(deps-dev): bump pytest from 9.0.3 to 9.1.0 #423, build(deps-dev): bump pytest from 9.1.0 to 9.1.1 #424)