Skip to content

allow to set json encoder#23

Open
AlexKovalevych wants to merge 3 commits into
bleacherreport:masterfrom
edenlabllc:json_encoder
Open

allow to set json encoder#23
AlexKovalevych wants to merge 3 commits into
bleacherreport:masterfrom
edenlabllc:json_encoder

Conversation

@AlexKovalevych

Copy link
Copy Markdown

No description provided.

@AlexKovalevych AlexKovalevych mentioned this pull request Jan 15, 2019
@bgmarx

bgmarx commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

Thanks for the PR! I'll look at it this week.

@scrogson scrogson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please rebase your changes on master?

Comment thread lib/plug/logger_json.ex Outdated
```

To use it, just plug it into the desired module.
To use it, set json_encoder parameter in you config:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you/your

@4xposed

4xposed commented Aug 12, 2019

Copy link
Copy Markdown

it would be nice if this PR could be merged as Poison is not the de-facto json encoder/decoder anymore.

@AlexKovalevych

Copy link
Copy Markdown
Author

Ok, i'll fix it on this week

@diogommartins

Copy link
Copy Markdown

Hey guys, I'm interested in using plug_logger_json and using Jason is a must for me. Having this Pull Request merged would make it possible, but I'm assuming it's currently stalled. @scrogson are you still interested in it? Can I join and make the changes myself ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants