Skip to content

Move JSON schema helpers to json ingestion gem#1201

Draft
jwils wants to merge 1 commit into
joshuaw/schema-extension-plumbingfrom
joshuaw/json-ingestion-extension
Draft

Move JSON schema helpers to json ingestion gem#1201
jwils wants to merge 1 commit into
joshuaw/schema-extension-plumbingfrom
joshuaw/json-ingestion-extension

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 20, 2026

Why

Keep the first extraction layer reviewable by moving the JSON Schema helper files without changing their contents, so GitHub can render them as renames instead of delete/add rewrites.

What

  • Move JSON Schema helper Ruby and RBS files into elasticgraph-json_ingestion
  • Update core requires/type references to load the helpers from the new gem
  • Add the Docker/Apollo build-context wiring needed for the new schema_definition dependency

Risk Assessment

Low to medium - mostly file moves plus require/dependency wiring.

References

  • Stacked on Add schema definition extension plumbing #1200.
  • git diff -M --summary reports the moved helper files as 100% renames, including json_schema_with_metadata.rb.
  • Local static checks passed for this layer before the Docker-only build-context amend; the full rewritten stack passes lint, type check, schema artifact check, dependency diagram verification, and spellcheck.

@jwils jwils force-pushed the joshuaw/schema-extension-plumbing branch from edb2d90 to ef7b7e5 Compare May 20, 2026 18:29
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch 3 times, most recently from 7eea290 to 461ba24 Compare May 20, 2026 19:56
@jwils jwils changed the title Extract JSON ingestion schema support Move JSON schema helpers to json ingestion gem May 20, 2026
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 461ba24 to 64ff2af Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 64ff2af to 7d4becc Compare May 21, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant