Move JSON schema helpers to json ingestion gem#1201
Draft
jwils wants to merge 1 commit into
Draft
Conversation
edb2d90 to
ef7b7e5
Compare
7eea290 to
461ba24
Compare
461ba24 to
64ff2af
Compare
64ff2af to
7d4becc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep the first extraction layer reviewable by moving the JSON Schema helper files without changing their contents, so GitHub can render them as renames instead of delete/add rewrites.
What
elasticgraph-json_ingestionRisk Assessment
Low to medium - mostly file moves plus require/dependency wiring.
References
git diff -M --summaryreports the moved helper files as 100% renames, includingjson_schema_with_metadata.rb.