Skip to content

Add lifecycle details to snapshot findings#79

Merged
yti93 merged 1 commit into
block:mainfrom
yti93:codex/snapshot-lifecycle-details
May 20, 2026
Merged

Add lifecycle details to snapshot findings#79
yti93 merged 1 commit into
block:mainfrom
yti93:codex/snapshot-lifecycle-details

Conversation

@yti93
Copy link
Copy Markdown
Contributor

@yti93 yti93 commented May 12, 2026

🤖 Draft PR opened by Youssef's AI agent.

Summary

  • Add required finding.lifecycle_details metadata to snapshot findings.
  • Populate lifecycle details from the existing VersionLifecycle data during drift detection.
  • Document the snapshot wire shape and add detection/snapshot regression tests.

Test plan

  • env GOCACHE=/private/tmp/version-guard-go-build GOMODCACHE=/private/tmp/version-guard-go-mod go test ./...

@yti93 yti93 force-pushed the codex/snapshot-lifecycle-details branch from ce76e42 to 54ec420 Compare May 12, 2026 18:06
@yti93 yti93 marked this pull request as ready for review May 12, 2026 18:16
@yti93 yti93 requested a review from a team as a code owner May 12, 2026 18:16
@yti93
Copy link
Copy Markdown
Contributor Author

yti93 commented May 12, 2026

@bakayolo Docker Compose test completed and verified:

  • Built and started the collector stack with Docker Compose.
  • Used live Wiz credentials and the rds-mysql report ID.
  • Triggered an rds-mysql scan through POST /scan.
  • Collector fetched 36 live RDS MySQL rows from Wiz.
  • Collector wrote the snapshot to MinIO.
  • Snapshot had 36 rds-mysql findings.
  • All 36 had lifecycle_details.
  • No findings had the removed Recommendation field.

@yti93 yti93 force-pushed the codex/snapshot-lifecycle-details branch from 3bd7948 to 10cdd19 Compare May 14, 2026 20:42
Signed-off-by: Youssef <53960652+yti93@users.noreply.github.com>
@yti93 yti93 force-pushed the codex/snapshot-lifecycle-details branch from 10cdd19 to a7a0ded Compare May 20, 2026 18:25
@yti93 yti93 merged commit b3be948 into block:main May 20, 2026
7 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 38.70968% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/types/lifecycle_details.go 0.00% 19 Missing ⚠️
Files with missing lines Coverage Δ
pkg/snapshot/store.go 85.23% <ø> (ø)
pkg/types/resource.go 100.00% <ø> (ø)
pkg/workflow/detection/activities.go 88.59% <100.00%> (ø)
pkg/types/lifecycle_details.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants