Skip to content

build(typescript): Upgrade toolchain and fix and improve rollup builder#1219

Merged
PetarKirov merged 15 commits into
mainfrom
build/ts/updates
Apr 16, 2025
Merged

build(typescript): Upgrade toolchain and fix and improve rollup builder#1219
PetarKirov merged 15 commits into
mainfrom
build/ts/updates

Conversation

@PetarKirov

@PetarKirov PetarKirov commented Apr 15, 2025

Copy link
Copy Markdown
Member

Toolchain upgrades

  • Node.js: 22.14.0 -> 23.11.0
  • Yarn: 4.5.0 -> 4.9.1
  • TypeScript: 5.5.4 -> 5.8.3
  • Storybook: 8.5.6 -> 8.6.12

Details

apps/rollup builder improvements

  • Enable source map rollup output based on tsconfig
    • This removes the following warning: image
  • Remove "Generated an empty chunk" warning which occur when transpiling a module containing only TS types
    • Example: image
  • Ensure the build fails on typechecking errors
    • Previously, an TS error in base-utils could go completely unnoticed: image

CLI UX

Command Before After
yarn build-single @blocksense/base-utils image image
yarn build-single @blocksense/base-utils error image image
yarn build @blocksense/data-feeds-config-generator error image image
yarn build @blocksense/data-feeds-config-generator image image
just build-ts image image

@EmilIvanichkovv EmilIvanichkovv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love the build logs improvements!

Left some questions

Comment thread nix/shells/pkg-sets/js.nix
Comment thread apps/rollup/bundle.mjs
Comment thread Justfile
Comment thread Justfile
Comment thread apps/rollup/bundle.mjs
Comment thread apps/rollup/bundle.mjs
Comment thread nix/filesets.nix
@EmilIvanichkovv

Copy link
Copy Markdown
Contributor

The CI fails tho.

@github-actions

Copy link
Copy Markdown

🚀 Deployment Links of Blocksense Network websites:

Website Latest Update Commit
🌱 Documentation 16.04.2025 11:09:32 0b86672
📖 UI Components 16.04.2025 11:09:32 0b86672
🏴‍☠ NFT website 16.04.2025 11:09:32 0b86672

@EmilIvanichkovv EmilIvanichkovv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.
image

The storybook deploy seems ok too.

yarn build:all still not works but this is not in the scope of this PR

@PetarKirov PetarKirov added this pull request to the merge queue Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants