Add --ner-label-index option to validate#9
Merged
Conversation
Member
ConstantineLignos
left a comment
ConstantineLignos
left a comment
There was a problem hiding this comment.
Some quick comments to look at before we meet tomorrow. Can you check what is causing the test failures as well?
Member
|
We’ll meet this afternoon, but before then please sort out why tests only pass on some Python versions and make sure to explicitly block the NER label index being zero (that is reserved for the token at the moment, but we’ll revisit). |
ConstantineLignos
force-pushed
the
ner-label-index
branch
2 times, most recently
from
10aa0e8 to
b4b7b78
Compare
ConstantineLignos
force-pushed
the
ner-label-index
branch
from
b4b7b78 to
318e01c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the
validatemethod by adding an optional--ner-label-indexflag, which specifies the column for the NER label. The default value is -1.