🎨 Palette: Improve accessibility for AgentCard buttons#108
Conversation
💡 What: Added aria-label, aria-hidden on inner svgs, and focus-visible rings to the icon-only 'Start/Stop work' and 'Configure' buttons in AgentCard.tsx. 🎯 Why: Without these attributes, screen readers cannot interpret the purpose of these icon-only buttons, and keyboard users do not receive clear visual feedback when navigating to them. ♿ Accessibility: Ensures full screen reader comprehension and prominent visual focus rings for keyboard navigation. Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request improves the accessibility of the AgentCard component by adding aria-label attributes to icon-only buttons, hiding decorative SVG elements with aria-hidden="true", and applying focus-visible styles for keyboard navigation. It also documents these accessibility practices in .jules/palette.md. The reviewer suggests extending these accessibility enhancements to the model selection dropdown by adding an aria-label and focus-visible ring styles.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <select | ||
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900" | ||
| value={agent.model || "Auto"} | ||
| onChange={(e) => onModelChange?.(agent.id, (e.currentTarget as HTMLSelectElement).value)} | ||
| onChange={(e) => | ||
| onModelChange?.( | ||
| agent.id, | ||
| (e.currentTarget as HTMLSelectElement).value, | ||
| ) | ||
| } | ||
| title="Modifier le modèle" | ||
| > |
There was a problem hiding this comment.
The <select> element is an interactive control but currently lacks an explicit accessible name (aria-label) and visible focus indicators (focus-visible styles). Since this pull request specifically focuses on improving keyboard navigation and screen reader accessibility for interactive elements in AgentCard, we should also ensure the model selector is fully accessible.
Adding aria-label="Modifier le modèle" and Tailwind's focus-visible:ring-2 focus-visible:ring-[#175B37] focus-visible:outline-none will ensure that keyboard users can clearly see when the select is focused, and screen readers can announce its purpose.
| <select | |
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900" | |
| value={agent.model || "Auto"} | |
| onChange={(e) => onModelChange?.(agent.id, (e.currentTarget as HTMLSelectElement).value)} | |
| onChange={(e) => | |
| onModelChange?.( | |
| agent.id, | |
| (e.currentTarget as HTMLSelectElement).value, | |
| ) | |
| } | |
| title="Modifier le modèle" | |
| > | |
| <select | |
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900 focus-visible:ring-2 focus-visible:ring-[#175B37] focus-visible:outline-none rounded" | |
| value={agent.model || "Auto"} | |
| onChange={(e) => | |
| onModelChange?.( | |
| agent.id, | |
| (e.currentTarget as HTMLSelectElement).value, | |
| ) | |
| } | |
| title="Modifier le modèle" | |
| aria-label="Modifier le modèle" | |
| > |
💡 What: Added aria-label, aria-hidden on inner svgs, and focus-visible rings to the icon-only 'Start/Stop work' and 'Configure' buttons in AgentCard.tsx.
🎯 Why: Without these attributes, screen readers cannot interpret the purpose of these icon-only buttons, and keyboard users do not receive clear visual feedback when navigating to them.
♿ Accessibility: Ensures full screen reader comprehension and prominent visual focus rings for keyboard navigation.
PR created automatically by Jules for task 3681085168294826251 started by @bobdivx