-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [performance improvement] Offload dashboard KPIs counting to Astro DB SQLite aggregations #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bobdivx
wants to merge
1
commit into
dev
Choose a base branch
from
jules-1457682352501705704-f58d7c0a
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
⚡ Bolt: [performance improvement] Offload dashboard KPIs counting to Astro DB SQLite aggregations #112
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ## 2025-01-30 - Replace length checks on full memory fetches with Astro DB aggregations | ||
|
|
||
| **Learning:** When retrieving counts for multiple tables or filtered sets (e.g. `Project`, `AgentTask`, `Request`) to display dashboard KPIs, performing full memory queries (using `db.select().from(Table)`) just to read their `.length` property creates significant N+1 and memory overhead, especially for larger data sets. In this codebase's architecture using Drizzle ORM over Astro DB, you can offload these aggregations directly to the database. | ||
|
|
||
| **Action:** Replaced full row fetches mapping to `.length` arrays in `src/pages/api/dashboard-kpis.ts` with direct Drizzle ORM `db.select({ count: count() })` along with appropriate `where` conditions (`eq`, `gte`, `inArray`). This performs the counting fully on the SQLite layer, dramatically reducing memory payload and computation time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original implementation used
isOpenQueueStatuswhich performed a case-insensitive check (.toLowerCase()) on the status field. By switching to a direct SQLinArraycomparison, the query is now case-sensitive in SQLite.If there is any chance of mixed-case status values being inserted into the database (e.g., by external agents or legacy data), they will no longer be counted.
To prevent this regression, it is highly recommended to ensure strict lowercase validation at the database insertion/ingestion layer (e.g., via Zod schemas or database defaults) so that the database remains clean and the queries can run efficiently without needing case-insensitive SQL functions.