🎨 Palette: Icon-only buttons accessibility in Agent Cards#113
Conversation
💡 What: Added aria-label, aria-hidden='true' to svg icons, and keyboard focus visibility to the start/stop and configure buttons in the AgentCard component. Also updated the .jules/palette.md journal. 🎯 Why: Icon-only buttons need descriptive aria-labels and clean SVGs to be properly accessible to screen readers, and clear focus outlines for keyboard navigation. 📸 Before/After: Visual changes limited to hover/focus states and DOM attribute structures. Playwright verification complete. ♿ Accessibility: Ensures that screen readers correctly announce the button purpose instead of reading SVG elements, and that keyboard users can easily see which button holds focus. Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request improves the accessibility of icon-only buttons in the AgentCard component by adding aria-label attributes, hiding decorative SVGs from screen readers with aria-hidden="true", and introducing visible keyboard focus indicators. It also updates the .jules/palette.md documentation to reflect these learnings. The reviewer suggested extending these accessibility improvements to the model selection dropdown (<select>) by adding an explicit aria-label and a focus-visible ring.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <select | ||
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900" | ||
| value={agent.model || "Auto"} | ||
| onChange={(e) => onModelChange?.(agent.id, (e.currentTarget as HTMLSelectElement).value)} | ||
| onChange={(e) => | ||
| onModelChange?.( | ||
| agent.id, | ||
| (e.currentTarget as HTMLSelectElement).value, | ||
| ) | ||
| } | ||
| title="Modifier le modèle" | ||
| > |
There was a problem hiding this comment.
The <select> element for changing the model has a title attribute but lacks an explicit aria-label and a visible focus indicator. To ensure robust accessibility for both screen readers and keyboard navigation (consistent with the improvements made to the buttons in this PR), please add an aria-label and focus-visible ring styles.
| <select | |
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900" | |
| value={agent.model || "Auto"} | |
| onChange={(e) => onModelChange?.(agent.id, (e.currentTarget as HTMLSelectElement).value)} | |
| onChange={(e) => | |
| onModelChange?.( | |
| agent.id, | |
| (e.currentTarget as HTMLSelectElement).value, | |
| ) | |
| } | |
| title="Modifier le modèle" | |
| > | |
| <select | |
| class="max-w-full cursor-pointer appearance-none truncate border-none bg-transparent pr-2 text-right font-mono text-[9px] text-gray-500 outline-none hover:text-gray-900 focus-visible:ring-2 focus-visible:ring-[#175B37] rounded-sm" | |
| value={agent.model || "Auto"} | |
| onChange={(e) => | |
| onModelChange?.( | |
| agent.id, | |
| (e.currentTarget as HTMLSelectElement).value, | |
| ) | |
| } | |
| title="Modifier le modèle" | |
| aria-label="Modifier le modèle" | |
| > |
💡 What: Added aria-label, aria-hidden='true' to svg icons, and keyboard focus visibility to the start/stop and configure buttons in the AgentCard component. Also updated the .jules/palette.md journal.
🎯 Why: Icon-only buttons need descriptive aria-labels and clean SVGs to be properly accessible to screen readers, and clear focus outlines for keyboard navigation.
📸 Before/After: Visual changes limited to hover/focus states and DOM attribute structures. Playwright verification complete.
♿ Accessibility: Ensures that screen readers correctly announce the button purpose instead of reading SVG elements, and that keyboard users can easily see which button holds focus.
PR created automatically by Jules for task 2112648422163099301 started by @bobdivx