🛡️ Sentinel: [CRITICAL] Fix command injection in docker logs API#115
🛡️ Sentinel: [CRITICAL] Fix command injection in docker logs API#115bobdivx wants to merge 1 commit into
Conversation
🚨 Severity: CRITICAL 💡 Vulnerability: Command injection in `src/pages/api/docker-logs.ts` where user input was concatenated directly into a shell string executed via `execSync`. 🎯 Impact: Arbitrary command execution on the host system. 🔧 Fix: Replaced `execSync` with `execFileAsync` passing parameters securely as an array, validated user inputs, and added a journal entry. ✅ Verification: Ran `pnpm run check` and `pnpm test` to ensure no regressions. Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a command injection vulnerability in the Docker logs API by replacing execSync with execFileAsync and introducing input validation for both containerId and tail. Feedback on the changes points out a regression where the string value 'all' is no longer supported for the --tail option, and suggests a fix to allow both 'all' and positive integers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| let tailCount = parseInt(tail, 10); | ||
| if (isNaN(tailCount) || tailCount < 1) { | ||
| tailCount = 100; | ||
| } | ||
|
|
||
| let logs: string[] = []; | ||
| try { | ||
| const output = execSync(command, { stdio: ['pipe', 'pipe', 'pipe'] }).toString(); | ||
| logs = output.trim().split('\n'); | ||
| const { stdout, stderr } = await execFileAsync('docker', ['logs', '--tail', tailCount.toString(), '--', containerId]); |
There was a problem hiding this comment.
The docker logs command supports both a numeric value and the string "all" for the --tail option. By parsing tail strictly as an integer, this change introduces a regression where passing tail=all is no longer supported and will silently default to 100.
We should allow both "all" and positive integers while still ensuring safe validation.
let tailParam = '100';
if (tail === 'all') {
tailParam = 'all';
} else {
const tailCount = parseInt(tail, 10);
if (!isNaN(tailCount) && tailCount >= 1) {
tailParam = tailCount.toString();
}
}
let logs: string[] = [];
try {
const { stdout, stderr } = await execFileAsync('docker', ['logs', '--tail', tailParam, '--', containerId]);
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command injection in
src/pages/api/docker-logs.tswhere user input was concatenated directly into a shell string executed viaexecSync.🎯 Impact: Arbitrary command execution on the host system.
🔧 Fix: Replaced
execSyncwithexecFileAsyncpassing parameters securely as an array, validated user inputs, and added a journal entry.✅ Verification: Ran
pnpm run checkandpnpm testto ensure no regressions.PR created automatically by Jules for task 17642776857423457004 started by @bobdivx