Skip to content

🎨 Palette: Enhance accessibility of icon-only composer buttons#119

Open
bobdivx wants to merge 1 commit into
devfrom
feature/palette-composer-accessibility-13961037320120391415
Open

🎨 Palette: Enhance accessibility of icon-only composer buttons#119
bobdivx wants to merge 1 commit into
devfrom
feature/palette-composer-accessibility-13961037320120391415

Conversation

@bobdivx

@bobdivx bobdivx commented Jun 15, 2026

Copy link
Copy Markdown
Owner

💡 What: Added ARIA labels, titles, hidden states for internal icons, and focus-visible rings to the send button and options menu button in the composer.
🎯 Why: Textual and SVG icon-only buttons are unreadable by screen readers without ARIA labels, and missing focus rings harm keyboard navigation accessibility.
📸 Before/After: Visual outline added for keyboard focus.
♿ Accessibility: Improved screen reader announcements and explicit keyboard focus visibility.


PR created automatically by Jules for task 13961037320120391415 started by @bobdivx

💡 What: Added ARIA labels, titles, hidden states for internal icons, and focus-visible rings to the send button and options menu button in the composer.
🎯 Why: Textual and SVG icon-only buttons are unreadable by screen readers without ARIA labels, and missing focus rings harm keyboard navigation accessibility.
📸 Before/After: Visual outline added for keyboard focus.
♿ Accessibility: Improved screen reader announcements and explicit keyboard focus visibility.

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forge Ready Ready Preview, Comment Jun 15, 2026 5:18pm

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the accessibility of icon-only buttons in the composer and discussion header components by adding ARIA labels, titles, focus-visible styling, and hiding raw icons from screen readers. The reviewer suggests further improving the options button in DiscussionHeader.tsx by adding aria-haspopup="true" and aria-expanded attributes to correctly communicate the state of the dropdown menu to assistive technologies.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 114 to 120
<button
type="button"
class="flex h-11 w-11 items-center justify-center rounded-full border border-gray-200 text-gray-500 transition hover:bg-gray-50 hover:text-gray-800"
class="flex h-11 w-11 items-center justify-center rounded-full border border-gray-200 text-gray-500 transition hover:bg-gray-50 hover:text-gray-800 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#175B37]"
onClick={() => setHeaderMenuOpen((v: boolean) => !v)}
aria-label="Ouvrir le menu d'options"
title="Options"
>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this button toggles the visibility of a dropdown menu (headerMenuOpen), it should indicate its expanded state and popup nature to screen readers using aria-haspopup="true" and aria-expanded={headerMenuOpen}. This ensures that assistive technologies are aware of the menu's state.

        <button
          type="button"
          class="flex h-11 w-11 items-center justify-center rounded-full border border-gray-200 text-gray-500 transition hover:bg-gray-50 hover:text-gray-800 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#175B37]"
          onClick={() => setHeaderMenuOpen((v: boolean) => !v)}
          aria-label="Ouvrir le menu d'options"
          title="Options"
          aria-haspopup="true"
          aria-expanded={headerMenuOpen}
        >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant