rename: LinearSolver.{INDIRECT,GPU,DENSE} -> {CPU_INDIRECT,GPU_INDIRECT,CPU_DENSE}#206
Merged
Merged
Conversation
…CT,CPU_DENSE} The old names were ambiguous along two axes: INDIRECT didn't say where the solver runs (CPU), and GPU didn't say what method (it's the indirect/iterative solver, not a direct one). The new names make location explicit and disambiguate from CUDSS (GPU direct). Both the enum member names and the underlying string values move to the new scheme. No internal users of the string form were found; if an external caller was passing `linear_solver="indirect"` etc., they will now see a ValueError from LinearSolver(...) construction. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
bodono
added a commit
to cvxgrp/scs
that referenced
this pull request
Apr 23, 2026
Companion to bodono/scs-python#206, which renamed LinearSolver.{INDIRECT,GPU,DENSE} -> {CPU_INDIRECT,GPU_INDIRECT,CPU_DENSE} to disambiguate location (CPU/GPU) and method (direct/indirect). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
bodono
added a commit
that referenced
this pull request
Apr 23, 2026
Follow-up to #206: the enum member list in the README still showed INDIRECT / GPU / DENSE. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinearSolverenum along two axes:INDIRECT→CPU_INDIRECT(location),GPU→GPU_INDIRECT(method),DENSE→CPU_DENSE(location, for consistency / future-proofing against a possible GPU-dense backend).Breaking change
Any caller using
scs.LinearSolver.INDIRECT/.GPU/.DENSEor the string forms"indirect"/"gpu"/"dense"must update. No internal callers of the string form exist; all in-tree enum usages are renamed in this PR.Test plan
🤖 Generated with Claude Code