Use the JUnit assertions the project actually has - #18
Merged
Conversation
Two test files I added imported `kotlin.test`, which is not on this project's test classpath — `junit:junit:4.13.2` is the only test dependency and every other Kotlin test imports `org.junit.Assert`. They compiled nowhere and broke the Android job on main, and therefore on every open pull request, including a documentation-only one. I wrote them without compiling because I had it recorded that Android could only be built in CI. That is wrong: `./gradlew --offline` builds and runs the full 235-test suite on this machine in seconds. Verified there before this commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XKX6zEAGiZFE5wAxJgYbV
bojieli
added a commit
that referenced
this pull request
Aug 25, 2026
The same mistake as the two files fixed in #18, caught before merging this time: kotlin.test is not on this project's test classpath. JUnit4 also wants a delta on a double comparison and puts the message first, so those are corrected too. Verified with ./gradlew --offline :app:testDebugUnitTest. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XKX6zEAGiZFE5wAxJgYbV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Two Kotlin test files I added in #9 and #10 import
kotlin.test, which is not on this project's test classpath.junit:junit:4.13.2is the only test dependency and every other Kotlin test importsorg.junit.Assert.That broke the Android job on
main, and therefore on every open pull request — including #12, which is documentation-only.Why I shipped it
I wrote those files without compiling them, because I had it recorded that Android could only be built in CI. That is wrong.
./gradlew --offlinebuilds and runs the full suite on a developer machine in seconds:Verified there before this commit. The note that said otherwise has been corrected.
The fix
Imports only — the assertions themselves are unchanged and the JUnit4 overloads resolve without edits.
🤖 Generated with Claude Code
https://claude.ai/code/session_015XKX6zEAGiZFE5wAxJgYbV