CI/docs: dasImgui is now part of the daslang tree - #29
Merged
Conversation
dasImgui merged into GaijinEntertainment/daScript as modules/dasImgui (built in-tree by default); borisbat/dasImgui is being archived. Adapt the overlay accordingly: - tests.yml / docs.yml: drop the separate borisbat/dasImgui checkout and its daspkg install; build dasModuleImgui + imguiApp + imguiAppHeadless from the daslang superbuild instead. Lint no longer needs -load_module dasImgui (in-tree modules resolve natively). - CMakeLists.txt: reword the dasImgui-not-found FATAL_ERROR hint (the lookup logic is unchanged - modules/dasImgui still resolves in-tree). - README.md / CLAUDE.md: dasImgui ships with daslang; no separate install step, no extra -load_module. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NcrnLGE9AEh8EAND3xYCRC
There was a problem hiding this comment.
Pull request overview
Updates this dasImguiImplot overlay to match the new reality that dasImgui now ships in-tree with daslang (under modules/dasImgui), removing CI steps and docs guidance that assumed a separate borisbat/dasImgui checkout/install.
Changes:
- CI: remove the separate
borisbat/dasImguicheckout and install steps; build ImGui-related targets from the daslang superbuild. - Docs/README/CLAUDE: reword instructions to reflect in-tree dasImgui and simplify example
daslang -load_moduleinvocations. - CMake: update the “dasImgui not found”
FATAL_ERRORhint to point users at the daslang tree layout instead of installing the archived repo.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates project requirements/build/run instructions to treat dasImgui as in-tree. |
| CMakeLists.txt | Rewords the missing-dasImgui error message to reference the daslang tree and expected layout. |
| CLAUDE.md | Updates guidance/examples and CI notes to reflect in-tree dasImgui and simplified module loading. |
| .github/workflows/tests.yml | Removes dasImgui checkout/install; adds ImGui-related build targets from the daslang superbuild. |
| .github/workflows/docs.yml | Removes dasImgui checkout/install; updates lint invocation and build targets accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dasImgui has merged into the main daslang repo (GaijinEntertainment/daScript, merge commit 40cc907f3) as
modules/dasImgui, built in-tree by default, and borisbat/dasImgui is about to be archived. daspkg now satisfiesrequire_package("dasImgui")from the in-tree module automatically. This PR adapts the overlay; dasImguiImplot itself stays an external package.CI workflows
borisbat/dasImguicheckout step and thedaspkg install ../dasImgui --globalstep — the daScript checkout now containsmodules/dasImgui. The overlay's own install stays.dasModuleImgui imguiApp imguiAppHeadlessto the daslangcmake --build ... --targetlists — the shared twins now build from the daslang superbuild, and the overlay's CMake links againstmodules/dasImguiartifacts.-load_module .../dasImgui(in-tree modules resolve natively); keep the overlay's own-load_module.Build / docs
FATAL_ERRORhint to point at the daslang tree instead ofdaspkg install github.com/borisbat/dasImgui. Lookup logic unchanged —${MODULES_DIR}/dasImguistill resolves in-tree when the package sits under a daslang tree'smodules/.-load_module dasImguiin the run/test commands.🤖 Generated with Claude Code
https://claude.ai/code/session_01NcrnLGE9AEh8EAND3xYCRC