CI/docs: dasImgui is in-tree in daslang (modules/dasImgui) - drop the sibling checkout - #43
Merged
Merged
Conversation
… sibling checkout dasImgui has merged into the main daslang repo (GaijinEntertainment/daScript, merge 40cc907f3) and builds in-tree by default; borisbat/dasImgui is being archived. dasImguiNodeEditor stays an external package, but its dependency now comes with the daslang checkout: - tests.yml/docs.yml: delete the borisbat/dasImgui checkout step and the 'daspkg install ../dasImgui --global' step; build the in-tree shared twins (dasModuleImgui imguiApp imguiAppHeadless) from the daslang superbuild instead - artifacts land in modules/dasImgui/, where this repo's CMake resolves them as a sibling of its daspkg-installed location. - docs.yml lint: drop '-load_module .../dasImgui' - in-tree modules resolve natively; keep this repo's own -load_module. - CMakeLists.txt: reword the not-found error hints (no lookup-logic change) - dasImgui ships with daslang; build daslang first. - README.md/CLAUDE.md: dasImgui is no longer daspkg-installed; dev junction's dasImgui half now points at the daslang tree's modules/dasImgui. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NcrnLGE9AEh8EAND3xYCRC
There was a problem hiding this comment.
Pull request overview
This PR updates dasImguiNodeEditor’s CI and documentation to treat dasImgui as an in-tree dependency of daslang (modules/dasImgui) rather than a separately checked-out / daspkg-installed sibling repo, aligning the build with current daslang structure and packaging.
Changes:
- CI: remove the external
borisbat/dasImguicheckout + install, and build the in-tree dasImgui targets (dasModuleImgui,imguiApp,imguiAppHeadless) directly from the daslang superbuild. - Docs CI: drop
-load_module <workspace>/dasImguiduring lint, relying on daslang’s in-treemodules/dasImgui. - Docs/CMake hints: update README/CLAUDE/CMake error messages to reflect dasImgui’s new in-tree location and build expectations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates dependency/build notes to describe dasImgui as shipped with daslang (modules/dasImgui). |
| CMakeLists.txt | Rewords fatal error hints to reference in-tree dasImgui and “build daslang first”. |
| CLAUDE.md | Updates developer workflow + test instructions to reflect in-tree dasImgui usage. |
| .github/workflows/tests.yml | Removes dasImgui checkout/install and adds dasImgui build targets to the daslang build step. |
| .github/workflows/docs.yml | Removes dasImgui checkout/install and relies on in-tree dasImgui for lint + doc generation prerequisites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+7
| # Headless live-driven integration suite for dasImguiNodeEditor. The node | ||
| # editor depends on dasImgui, which is part of the daslang tree | ||
| # (modules/dasImgui) — the daslang checkout provides it, and the daslang build | ||
| # below produces the dasModuleImgui/imguiApp/imguiAppHeadless shared twins the | ||
| # node-editor C++ module links (see CMakeLists.txt). Only this repo is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dasImgui has merged into the main daslang repo (GaijinEntertainment/daScript, merge
40cc907f3) asmodules/dasImguiand now builds in-tree by default; borisbat/dasImgui is about to be archived. daspkg satisfiesrequire_package("dasImgui")from the in-tree module automatically, and the daspkg index no longer lists it. dasImguiNodeEditor stays an external package — this PR retargets its CI and docs at the in-tree dependency.What changed
.github/workflows/tests.yml+.github/workflows/docs.ymlborisbat/dasImguicheckout step — the daslang checkout already containsmodules/dasImgui.daspkg install ../dasImgui --globalstep; this repo's own install stays.dasModuleImgui imguiApp imguiAppHeadlessto the daslangcmake --build --targetlist — the shared twins now come from the daslang superbuild, with artifacts landing inmodules/dasImgui/, exactly where this repo's CMake resolves them as a sibling of its daspkg-installed location (mirrors daslang's ownnightly_imgui.ymltarget list).-load_module <workspace>/dasImgui(in-tree modules resolve natively from the daslang tree); kept this repo's own-load_module.CMakeLists.txt— reworded the three not-foundFATAL_ERRORhints (the old one suggesteddaspkg install github.com/borisbat/dasImgui) to say dasImgui ships with daslang atmodules/dasImguiand daslang must be built first. No lookup-logic changes.README.md/CLAUDE.md— install/dev instructions no longer daspkg-install dasImgui; the dev junction's dasImgui half now points at the daslang tree'smodules/dasImgui(this repo's own junction mechanics unchanged).Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01NcrnLGE9AEh8EAND3xYCRC