This repository was archived by the owner on Aug 17, 2026. It is now read-only.
Retire the integration lane's standing lint findings - #82
Merged
Conversation
The lane's lint step reports 7 findings on master, none newer than the rules that added them (STYLE040 and PERF031 postdate every file's last touch), so every PR opened today inherits a red step it didn't cause. - vulkan_boost: set_extent_2d absorbs the four 2D-extent runs, and push_memory_management_extensions the extension trio both device creators carry. - vulkan_imgui_app: the no-scene harness_end_frame delegates to the block overload with an empty scene - same frame, 11 fewer lines. - vk_model / vk_naming: the dim-scan and vendor-tag loops walk a peek_data view, so nothing re-strlens the source per iteration. Regenerated output is byte-identical, so the rewrites are proven behavior-preserving. The one finding left is vulkan_cmds' jagged-view STYLE040, which #81 removes in the emitter - the honest fix for a generated file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes longstanding lint warnings on master by refactoring a few hot-path string scans in the generator and deduplicating repeated boost-layer helper logic, keeping the Vulkan bindings/boost layer lint-clean without changing emitted outputs.
Changes:
- Generator: use
peek_dataviews invk_model.dasandvk_naming.dasto avoid repeated string-length rescans during loops. - Boost layer: factor repeated “memory management extension” pushes and common 2D image extent assignments into private helpers in
vulkan_boost.das. - ImGui harness: make the no-argument
harness_end_frame()delegate to the block overload invulkan_imgui_app.dasto reduce duplicated frame-finalization code.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| generator/vk_naming.das | Refactors vendor-tag stripping to iterate over a peek_data view for better lint/perf characteristics. |
| generator/vk_model.das | Refactors numeric array-dimension scanning to iterate over a peek_data view with an index cursor. |
| daslib/vulkan_imgui_app.das | Delegates harness_end_frame() to the block overload with an empty scene block to dedupe logic. |
| daslib/vulkan_boost.das | Adds small private helpers to remove duplicated extension-push logic and 2D extent setup in image creation helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| var found_tag = "" | ||
| peek_data(s) $(d) { | ||
| for (t in tags) { | ||
| // require a lowercase char right before the tag so "VkASTC..." doesn't lose a fake tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration lane's lint step reports 7 findings on master, all older than the rules that flag them (STYLE040 / PERF031 landed daslang-side after every file's last touch), so any PR opened against master today inherits a red step it didn't cause — #81 is eating that right now. This clears our side:
daslib/vulkan_boost.das—set_extent_2dabsorbs the four 2D-extent runs (width / height / depth = 1), andpush_memory_management_extensionsthe memory-extension trio both device creators duplicate.daslib/vulkan_imgui_app.das— the no-sceneharness_end_framedelegates to the block overload with an empty scene: identical frame, 11 fewer lines.generator/vk_model.das/vk_naming.das— the dim-scan and vendor-tag loops walk apeek_dataview, so nothing re-strlens the source per iteration. Regenerated output is byte-identical (skip report and all four generated daslib files diffed against a fresh run), so the rewrites are proven behavior-preserving.Verified locally with the CI-shaped whole-tree gate: 150 files, 1 issue, 0 errors — the one left is
vulkan_cmds.das's jagged-view STYLE040, which #81 removes in the emitter (the honest fix for a generated file; a hand-edit would die on regen and fail the ratchet diff). The lane goes fully green once both land. Note my local gate also compilesvulkan_imgui_app.das, which CI's daslang (no dasImgui) skips — that file's finding was invisible to CI but real.🤖 Generated with Claude Code