This repository was archived by the owner on Aug 17, 2026. It is now read-only.
Drop stale PERF030 nolints that now fail the lint gate as LINT019 - #83
Merged
Conversation
The daslang lint sweep (#3733) taught PERF030 to recognize the delete-just-above / fresh-local move-assign shape, so these 27 suppressions suppress nothing and LINT019 (stale nolint) reds the CI lint gate on every master push. Comment-only change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes stale // nolint:PERF030 suppressions that are no longer applicable after an upstream daslang lint change, avoiding LINT019 (stale nolint) failures and restoring the lint gate to green. These are comment-only edits that keep the underlying swapchain recreation logic unchanged.
Changes:
- Strips the obsolete trailing
// nolint:PERF030 - deleted just abovecomment from swapchain recreation sites. - Applies the same cleanup to the boost window helper (
daslib/vulkan_window.das) and multiple windowed tutorial drivers.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| daslib/vulkan_window.das | Removes stale nolint:PERF030 on swapchain recreate move-assign. |
| tutorials/02_mandelbrot/window/show_mandelbrot_blit.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/03_sdf/window/show_sdf.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/04_cube/window/show_cube.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/05_instancing/window/show_instancing.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/06_skybox/window/show_skybox.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/07_particles/window/show_particles.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/08_shadow/window/show_shadow.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/09_msaa/window/show_msaa.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/10_deferred/window/show_deferred.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/11_hdr/window/show_hdr.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/12_gpu_driven/window/show_gpu_driven.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/14_teapot/window/show_teapot.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
| tutorials/15_raytracing/window/show_raytracing.das | Removes stale nolint:PERF030 on swapchain recreation paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's Integration lane is red since the last two merges: the daslang lint sweep (GaijinEntertainment/daScript#3733) taught PERF030 to recognize the delete-just-above / fresh-local move-assign shape, so the
// nolint:PERF030tags on our swapchain-recreate lines now suppress nothing, and LINT019 (stale nolint) fails the gate. This drops all 27 stale tags: one indaslib/vulkan_window.das(the only one CI sees — the headless build skipswindow/drivers) and 26 in the windowed tutorial drivers (caught by the full local lint, which covers what CI skips). The live suppression ingenerator/generate.dasstill fires and stays.Where to look: any one file — all 27 edits are the identical trailing-comment strip.
Validation, claims, ledger
Validation
9709b647: 150 files, 0 issues, 0 skipped — strictly wider than CI's gate (CI skips 33 headless-excluded files).Claims — stated, not tested
🤖 Generated with Claude Code