Skip to content
This repository was archived by the owner on Aug 17, 2026. It is now read-only.

Drop stale PERF030 nolints that now fail the lint gate as LINT019 - #83

Merged
borisbat merged 1 commit into
masterfrom
bbatkin/stale-perf030-nolints
Aug 15, 2026
Merged

Drop stale PERF030 nolints that now fail the lint gate as LINT019#83
borisbat merged 1 commit into
masterfrom
bbatkin/stale-perf030-nolints

Conversation

@borisbat

Copy link
Copy Markdown
Owner

Master's Integration lane is red since the last two merges: the daslang lint sweep (GaijinEntertainment/daScript#3733) taught PERF030 to recognize the delete-just-above / fresh-local move-assign shape, so the // nolint:PERF030 tags on our swapchain-recreate lines now suppress nothing, and LINT019 (stale nolint) fails the gate. This drops all 27 stale tags: one in daslib/vulkan_window.das (the only one CI sees — the headless build skips window/ drivers) and 26 in the windowed tutorial drivers (caught by the full local lint, which covers what CI skips). The live suppression in generator/generate.das still fires and stays.

Where to look: any one file — all 27 edits are the identical trailing-comment strip.

Validation, claims, ledger

Validation

  • Full-tree local lint with daslang master 9709b647: 150 files, 0 issues, 0 skipped — strictly wider than CI's gate (CI skips 33 headless-excluded files).

Claims — stated, not tested

  • Integration suite not re-run for this tip: comment-only diff; the lint pass compile-checks all 150 files, and the same tree ran the suite 42/42 on real HW yesterday.

🤖 Generated with Claude Code

The daslang lint sweep (#3733) taught PERF030 to recognize the
delete-just-above / fresh-local move-assign shape, so these 27
suppressions suppress nothing and LINT019 (stale nolint) reds the
CI lint gate on every master push. Comment-only change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 14, 2026 23:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes stale // nolint:PERF030 suppressions that are no longer applicable after an upstream daslang lint change, avoiding LINT019 (stale nolint) failures and restoring the lint gate to green. These are comment-only edits that keep the underlying swapchain recreation logic unchanged.

Changes:

  • Strips the obsolete trailing // nolint:PERF030 - deleted just above comment from swapchain recreation sites.
  • Applies the same cleanup to the boost window helper (daslib/vulkan_window.das) and multiple windowed tutorial drivers.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
daslib/vulkan_window.das Removes stale nolint:PERF030 on swapchain recreate move-assign.
tutorials/02_mandelbrot/window/show_mandelbrot_blit.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/03_sdf/window/show_sdf.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/04_cube/window/show_cube.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/05_instancing/window/show_instancing.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/06_skybox/window/show_skybox.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/07_particles/window/show_particles.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/08_shadow/window/show_shadow.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/09_msaa/window/show_msaa.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/10_deferred/window/show_deferred.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/11_hdr/window/show_hdr.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/12_gpu_driven/window/show_gpu_driven.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/14_teapot/window/show_teapot.das Removes stale nolint:PERF030 on swapchain recreation paths.
tutorials/15_raytracing/window/show_raytracing.das Removes stale nolint:PERF030 on swapchain recreation paths.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@borisbat
borisbat merged commit 68bf3c1 into master Aug 15, 2026
6 checks passed
@borisbat
borisbat deleted the bbatkin/stale-perf030-nolints branch August 15, 2026 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants