This repository was archived by the owner on Aug 17, 2026. It is now read-only.
Ratchet the copyability report in CI, and fix the opt_struct_ptr doc-comment - #84
Merged
Conversation
…comment Two follow-ups from the #81 review ledger: - The generator already writes copyability_report.txt beside the skip report; the ratchet step now diffs it against the committed copy, so a copyable -> non-copyable flip in the boost surface fails CI instead of relying on committed regen. Verified locally: today's regen matches both reports. - FieldKind.opt_struct_ptr said "(caller's addr; cloned into scratch)" - both halves stale since the view rework: the pointee is borrowed and raw-viewed into the parent view's scratch, and the raw pointer aims at that scratch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR tightens the generator “ratchet” CI gate by also diffing the regenerated copyability_report.txt against the committed baseline, and corrects the FieldKind.opt_struct_ptr documentation to reflect the current “borrowed pointee, raw-viewed into scratch” behavior in the boost view layer.
Changes:
- CI: Extend the existing skip-ratchet step to also
diffgenerator/copyability_report.txtagainst the regenerated/tmp/copyability_report.txt. - Generator docs: Update
FieldKind.opt_struct_ptr’s doc-comment to match post–view-rework semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
generator/vk_emit_boost.das |
Updates the opt_struct_ptr doc-comment to describe borrowed/raw-view behavior accurately. |
.github/workflows/tests.yml |
Adds a CI diff check for copyability_report.txt alongside the existing skip report ratchet. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from #81's review ledger. The ratchet step now also diffs the regenerated
copyability_report.txtagainst the committed copy — the generator already writes it beside the skip report, so a copyable → non-copyable flip in the boost surface fails CI instead of relying on committed regen. AndFieldKind.opt_struct_ptr's doc-comment said "(caller's addr; cloned into scratch)" — both halves stale since the view rework: the pointee is borrowed and raw-viewed into the parent view's scratch.Validation, claims
Validation
generator/vk_emit_boost.daslints clean.Claims — stated, not tested
🤖 Generated with Claude Code