Capture Claude hook permission and system prompt context - #95
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f892507d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
do we attach permission to every span?
|
Only the root span. |
|
should we also attach this to turn spans, and tool calls? If users change permission mode while the session is ongoing. |
|
Yep, doing that now. Uncertain about system prompt...does that change with permission mode? Should that be on every turn too? |
|
I think system prompt doesn't need to be on every turn. We can always change if something comes up. |
|
Yeah, I left system prompt as root-level, just changed the permission mode to be per-turn. |
2 participants
Summary
Validation
cargo fmt --manifest-path bt-daemon/Cargo.toml --checkcargo test --manifest-path bt-daemon/Cargo.toml --all-features --lockedmake validate-claudeCloses SDK-407
Closes SDK-408