refactor: narrow trace host route selection - #97
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aee60b0cfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
force-pushed
the
fix/narrow-trace-host-contract
branch
from
September 23, 2026 18:34
b73a4f7 to
9d31a80
Compare
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
September 23, 2026 18:44
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 23, 2026
Stephen Belanger (Qard)
added a commit
to braintrustdata/bt
that referenced
this pull request
Sep 23, 2026
## Summary - Pin `bt-daemon` to the merged plugins [PR #97](braintrustdata/braintrust-coding-agent-plugins#97) revision in `Cargo.toml` and `Cargo.lock`. - Return `HostRouteSelection` from bt's trace host, containing only the auth selection and default project name. - Let the daemon construct its own session route and trace-specific settings. ## Validation - `cargo test --locked --bin bt` (830 passed) - `pre-commit run --all-files --show-diff-on-failure` (all hooks passed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrow the embedded trace host contract to the values
btactually selects: a non-secret auth selection and an optional default project name. The trace runtime now buildsSessionRoutein one place, maps the project to a project-logs destination, and owns flush mode, metadata, tags, and span plugins.Trace commands continue to own plugin flags, persistent setup settings, and managed-run overlays. Import keeps its explicit experiment and parent-span destination arguments; the standalone daemon CLI keeps its own route arguments. The embedded
bt trace enableandbt trace runcommands currently select a default project throughbt's global--projectoption.Why
Adding
span_pluginsto the daemon's wire route broke thebtconsumer because its host callback returned the wholeSessionRoute. Future trace settings should not require changes to the embedding CLI's route construction.Validation
cargo test --manifest-path bt-daemon/Cargo.toml --all-features --lockedcargo clippy --manifest-path bt-daemon/Cargo.toml --all-features --all-targets --locked -- -D warningscargo fmt --manifest-path bt-daemon/Cargo.toml --checkThe
btdependency remains pinned to its existing daemon revision. A follow-upbtchange can adoptHostRouteSelectionwhen the pin advances.