Skip to content

fix: Fix dataset snapshots silently including deleted rows - #2512

Merged
Luca Forstner (lforst) merged 2 commits into
mainfrom
lforst/dum-e/barcelona-dfd39b8082
Sep 23, 2026
Merged

Luca Forstner (lforst) merged 2 commits into
mainfrom
lforst/dum-e/barcelona-dfd39b8082

Conversation

@lforst

Copy link
Copy Markdown
Member

Closes braintrustdata/braintrust-sdk-javascript#2492

  • Fix dataset snapshots including deleted rows.
  • Previously, snapshots used the newest transaction from surviving rows, which could point to a moment before the deletions.
  • After uploading pending changes, request a current transaction ID from the server so snapshots include deletions even when every row has been deleted. Datasets pinned to a specific historical version keep that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset.createSnapshot() pins a pre-delete transaction id after delete-only edits (version() ignores tombstones)

2 participants