fix(pydantic-ai): avoid duplicate request customization - #749
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoSep 9, 2026
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Capture tool metadata from the normal `prepare_request` result instead of calling `customize_request_parameters` during span construction. This preserves provider-adjusted tool schemas while avoiding side effects and divergent trace metadata. Add VCR-backed coverage for direct and streaming requests with a stateful customization hook.
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-fix-pydantic-ai-request-customization
branch
from
September 8, 2026 18:28
327aedd to
98041ec
Compare
Andrew Kent (realark)
approved these changes
Sep 9, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-pydantic-ai-request-customization
branch
September 9, 2026 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture tool metadata from the normal
prepare_requestresult instead of callingcustomize_request_parameters.customize_request_parameterscauses a side effect, which is no beuno for us (we can't be affecting customer code during our instrumentation).