feat: add span customizers (SDK-316) - #788
Merged
Merged
Conversation
Andrew Kent (realark)
force-pushed
the
ark/SDK-316-span-customizers
branch
4 times, most recently
from
September 23, 2026 19:27
0bae7f4 to
cbcc96b
Compare
Andrew Kent (realark)
marked this pull request as ready for review
September 23, 2026 19:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbcc96b492
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Andrew Kent (realark)
force-pushed
the
ark/SDK-316-span-customizers
branch
from
September 23, 2026 20:01
cbcc96b to
3c50024
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 23, 2026
Andrew Kent (realark)
force-pushed
the
ark/SDK-316-span-customizers
branch
from
September 23, 2026 21:38
3c50024 to
d82dbd0
Compare
add customizers and re-implement masking fn with a customizer
Andrew Kent (realark)
force-pushed
the
ark/SDK-316-span-customizers
branch
from
September 23, 2026 21:39
d82dbd0 to
634503e
Compare
Andrew Kent (realark)
enabled auto-merge (squash)
September 23, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Generated Description
Summary
Implements SDK-316 using the span customizer specification and the JavaScript reference.
SpanCustomizer.on_span_export,SpanExportData,set_span_customizers, andauto_instrument(span_customizers=...).Verification
test_types: pyright/mypy clean, 35 runtime tests passed.The core suite required clearing local Braintrust endpoint environment overrides to match recorded cassettes. It exits successfully but prints an atexit closed-output-stream warning. No cassettes were changed.
Contract note
Like JavaScript, failures are fail open. Throwing is not a safe way to block export; the API docs state this explicitly.