fix(agno): preserve session ids across resumed runs - #792
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoSep 22, 2026
Merged
Conversation
When an Agno run pauses for a client-side tool, resuming it bypasses the instrumented run methods. Subsequent model calls become unrelated trace roots. Instrument `continue_run` and `acontinue_run` on Agent and Team, and preserve Agno's `session_id` in task span metadata, including generated IDs and per-call overrides. Separate requests can produce separate traces with a shared session ID. Before: initial trace: task -> llm -> pause resume trace: llm After: initial trace: task [session_id=S] -> llm -> pause resume trace: task [session_id=S] -> llm Resumes retain the caller's parent span when one exists. Without an ambient parent, the shared `metadata.session_id` correlates the separate traces. Refs #764
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b9838d0d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Agno continuation streams left their task span current between iterations.
Closing or abandoning a stream could leak context, and dropping an unstarted
iterator never finalized its span.
Before:
caller -> create stream -> continuation stays current
-> close/drop -> incomplete cleanup
After:
caller -> create stream -> caller context restored
-> next/await -> isolated stream context -> caller context restored
-> close/drop -> log partial output and end span once
Keep suspended provider spans in the stream's context across sync and async
iteration. Finalize on exhaustion, errors, cancellation, explicit close, or GC,
including streams that were never consumed. Async GC finalizes trace state
without scheduling provider cleanup on the event loop.
Refs #764
Abhijeet Prasad (AbhiPrasad)
deleted the
fix/agno-session-id-and-resume-tracing
branch
September 22, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Summary
When an Agno run pauses for a client-side tool, resuming it bypasses the instrumented run methods. Subsequent model calls become unrelated trace roots.
Instrument
continue_runandacontinue_runon Agent and Team, and preserve Agno'ssession_idin task span metadata, including generated IDs and per-call overrides. Separate requests can produce separate traces with a shared session ID.Before:
After:
Resumes retain the caller's parent span when one exists. Without an ambient parent, the shared
metadata.session_idcorrelates the separate traces.resolves #764