chore: Update platform types - #804
braintrust-bot[bot] wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dafb312a00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| class AnyModelParamsChatTemplateKwargs(TypedDict): | ||
| enable_thinking: NotRequired[bool | None] |
There was a problem hiding this comment.
When a caller passes a provider-specific chat-template option other than enable_thinking (for example, {"chat_template_kwargs": {"foo": "bar"}}), static type checkers reject the value because this TypedDict is closed. The generated schema for this field explicitly has additionalProperties: {}, so arbitrary keys are valid and PromptBuilder.create() forwards params unchanged; type it as a mapping that retains enable_thinking or otherwise permits additional keys.
Useful? React with 👍 / 👎.
Automated regeneration of SDK types.