Skip to content

feat: Add commands for pushing and previewing custom views #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luca Forstner (lforst) merged 4 commits into from
Sep 24, 2026
Merged

feat: Add commands for pushing and previewing custom views #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99b2ee0
feat: Add commands for pushing and previewing custom views
lforst Sep 23, 2026
aadaa32
fix: address custom view command review feedback
lforst Sep 23, 2026
6e2cf1f
Merge origin/main into custom views branch
lforst Sep 23, 2026
56f1e07
Merge origin/main into lforst/dum-e/istanbul-9d5dadcff3
lforst Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/release-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ jobs:
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
fi

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) Sep 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we match w/ mise?

- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate
- name: Install JS dependencies
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Install sha256sum (macOS ARM64)
if: ${{ runner.os == 'macOS' && runner.arch == 'ARM64' }}
shell: bash
Expand Down Expand Up @@ -229,6 +239,16 @@ jobs:

- run: chmod +x ~/.cargo/bin/dist

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"
- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate
- name: Install JS dependencies
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Fetch local artifacts
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,18 @@ jobs:
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
fi

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"

- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate

- name: Install JS dependencies
run: pnpm install --ignore-scripts

- name: Install sha256sum (macOS ARM64)
if: ${{ runner.os == 'macOS' && runner.arch == 'ARM64' }}
shell: bash
Expand Down Expand Up @@ -293,6 +305,18 @@ jobs:

- run: chmod +x ~/.cargo/bin/dist

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"

- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate

- name: Install JS dependencies
run: pnpm install --ignore-scripts

- name: Fetch local artifacts
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,21 @@ jobs:
uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9 # master
with:
toolchain: 1.97.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"
- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate
- name: Install JS dependencies
run: pnpm install --frozen-lockfile --ignore-scripts
- name: Run all unit tests
run: cargo test --locked --bin bt
- name: Test custom view CLI and preview callbacks
run: |
cargo test --locked --test cli custom_views
node --test scripts/custom-views-preview.test.mjs

eval-tests-go:
name: eval-tests-go
Expand All @@ -53,6 +66,15 @@ jobs:
uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9 # master
with:
toolchain: 1.97.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"
- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate
- name: Install JS dependencies
run: pnpm install --frozen-lockfile --ignore-scripts
# No Go toolchain is installed on purpose: these tests stub `go` through
# BT_EVAL_GO_BIN, so they stay hermetic and fast. Exercising a real
# `go run` would need a fixture under tests/evals/go plus actions/setup-go.
Expand Down Expand Up @@ -133,5 +155,14 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
- uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5.4.2
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.15.0"
- name: Enable pnpm
run: |
corepack enable
corepack prepare pnpm@10.28.2 --activate
- name: Install JS dependencies
run: pnpm install --ignore-scripts
- name: Run eval fixtures
run: cargo test --test eval_fixtures
Loading
Loading