feat: Publish @braintrust/bt on npm - #378
Luca Forstner (lforst) wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a20f6f35d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| fi | ||
| echo "Publishing $name@$version" | ||
| (cd "$dir" && npm publish --access public) | ||
| (cd "$dir" && npm publish --access public --tag latest) |
There was a problem hiding this comment.
latest during older-tag replays
When the documented manual-release path is used with an older existing tag (CONTRIBUTING.md:113), this command publishes the newly added wrapper with --tag latest, replacing the current latest dist-tag with that older version. The npm 11 documentation confirms that unversioned installs resolve the latest tag, so subsequent npm install @braintrust/bt calls are downgraded until the tag is repaired; only assign latest after verifying this release version is the newest, or publish replays under a non-latest tag.
Useful? React with 👍 / 👎.
| https | ||
| .get(url, (response) => { |
There was a problem hiding this comment.
When optional dependencies are omitted and the registry accepts the connection but stops responding, this postinstall request has no request or socket timeout, so npm install can hang indefinitely rather than reaching the documented download-failure path. Add a finite timeout that destroys the request and rejects with an actionable error.
Useful? React with 👍 / 👎.
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
should we not use the release action for this?
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Stephen Belanger (Qard)
left a comment
Stephen Belanger (Qard)
left a comment
There was a problem hiding this comment.
Generally LGTM, but unclear which slack channel that is routing to. Might benefit from a comment mapping the internal ID to the actually recognizable one.
| on_release_branch: ${{ needs.plan.outputs.on-release-branch }} | ||
| commit_message: ${{ needs.plan.outputs.commit-message }} | ||
| slack_token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
| slack_channel: C0ABHT0SWA2 |
There was a problem hiding this comment.
Which channel is this?
This branch has not been deployed
3 participants
No description provided.