Skip to content

Add POST /automation/trigger to ingress rules #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianvans (brianvans) wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −6
Open

Add POST /automation/trigger to ingress rules #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion braintrust/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ route these paths:
| --- | --- |
| `braintrust-api` (default) | All requests not matched by an explicit ingest or background route |
| `braintrust-api-ingest` | `POST /logs3`, `POST /otel/v1/traces`, `POST /attachment`, `POST /attachment/status` |
| `braintrust-api-background` | `POST /v1/eval`, `POST /v1/eval/*`, `POST /function/eval`, `POST /function/sandbox`, `POST /function/use`, `POST /function/invoke-async-batch`, `POST /function/insert-functions`, `POST /automation/logs/trigger`; all methods for `/v1/proxy/chat/completions`, `/v1/proxy/responses` |
| `braintrust-api-background` | `POST /v1/eval`, `POST /v1/eval/*`, `POST /function/eval`, `POST /function/sandbox`, `POST /function/use`, `POST /function/invoke-async-batch`, `POST /function/insert-functions`, `POST /automation/logs/trigger`, `POST /automation/trigger`; all methods for `/v1/proxy/chat/completions`, `/v1/proxy/responses` |

By default, Brainstore's internal `BRAINSTORE_AI_PROXY_URL` targets the
background Service while isolation is enabled. For an existing deployment,
Expand Down
3 changes: 3 additions & 0 deletions braintrust/files/contracts/api-workload-isolation-routes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ pools:
- path: /automation/logs/trigger
pathType: exact
method: POST
- path: /automation/trigger
pathType: exact
method: POST
- path: /v1/proxy/chat/completions
pathType: exact
- path: /v1/proxy/responses
Expand Down
19 changes: 14 additions & 5 deletions braintrust/tests/virtualservice_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,18 +292,27 @@ tests:
path: spec.http[5].match[0].method.exact
value: POST
- equal:
path: spec.http[13].match[0].uri.exact
path: spec.http[12].match[0].uri.exact
value: /automation/trigger
- equal:
path: spec.http[12].route[0].destination.host
value: custom-background
- equal:
path: spec.http[12].match[0].method.exact
value: POST
- equal:
path: spec.http[14].match[0].uri.exact
value: /v1/proxy/responses
- equal:
path: spec.http[13].route[0].destination.host
path: spec.http[14].route[0].destination.host
value: custom-background
- isNull:
path: spec.http[13].match[0].method
path: spec.http[14].match[0].method
- equal:
path: spec.http[14].match[0].uri.prefix
path: spec.http[15].match[0].uri.prefix
value: /
- equal:
path: spec.http[14].route[0].destination.host
path: spec.http[15].route[0].destination.host
value: braintrust-api

- it: should reject workload-isolation routes without the API pools
Expand Down
Loading