Skip to content

Strip unsupported params from gpt-6 models #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erin McNulty (erin2722) merged 4 commits into from
Sep 22, 2026
Merged

Strip unsupported params from gpt-6 models #462

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
718c779
strip temp
erin2722 Sep 22, 2026
c67cb69
oops
erin2722 Sep 22, 2026
9ededae
fix for bedrock too
erin2722 Sep 22, 2026
d4d18e9
oops
erin2722 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions crates/lingua/src/providers/openai/capabilities.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ const MODEL_TRANSFORM_RULES: &[(&str, &[ModelTransform])] = &[
"gpt-5",
&[StripTemperature, StripTopP, ForceMaxCompletionTokens],
),
(
"gpt-6",
&[StripTemperature, StripTopP, ForceMaxCompletionTokens],
),
// TODO: would be nice if we could apply these rules by provider instead of model name, and
// apply these to all Mistral models
("mistral", &[ForceMaxTokens]),
Expand All @@ -58,9 +62,9 @@ const MODEL_TRANSFORM_RULES: &[(&str, &[ModelTransform])] = &[

/// Get the transforms required for a model.
pub fn get_model_transforms(model: &str) -> &'static [ModelTransform] {
let lower = model.to_ascii_lowercase();
let normalized = normalize_openai_model_name(model);
for (prefix, transforms) in MODEL_TRANSFORM_RULES {
if lower.starts_with(prefix) {
if normalized.starts_with(prefix) {
return transforms;
}
}
Expand Down Expand Up @@ -155,7 +159,10 @@ impl EffortFamily {

fn normalize_openai_model_name(model: &str) -> String {
let lower = model.to_ascii_lowercase();
if let Some(stripped) = lower.strip_prefix("openai/") {
if let Some(stripped) = lower
.strip_prefix("openai/")
.or_else(|| lower.strip_prefix("openai."))
{
stripped.to_string()
} else {
lower
Expand Down Expand Up @@ -368,6 +375,14 @@ mod tests {
"gpt-5-mini",
&[StripTemperature, StripTopP, ForceMaxCompletionTokens][..],
),
(
"openai.gpt-6-astra",
&[StripTemperature, StripTopP, ForceMaxCompletionTokens][..],
),
(
"openai/gpt-6-astra",
&[StripTemperature, StripTopP, ForceMaxCompletionTokens][..],
),
("gpt-4", &[][..]),
("gpt-4o", &[][..]),
("claude-3", &[][..]),
Expand Down
Loading