Skip to content

Add closure-run identity correlation - #26

Merged
briancl2 merged 1 commit into
mainfrom
codex/issue164-customernewsletter-closure-identity
Jun 9, 2026
Merged

Add closure-run identity correlation#26
briancl2 merged 1 commit into
mainfrom
codex/issue164-customernewsletter-closure-identity

Conversation

@briancl2

@briancl2 briancl2 commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds tools/emit_closure_identity.py to emit comparable local and GitHub closure-run identity JSON fields: closure_run_id, closure_phase, closure_trigger, evidence_reuse_key, parent_command, github_run_id, and github_run_attempt.
  • Wires local validation through make closure-identity / make check and adds the focused make test-closure-identity regression to tools/test_all.sh.
  • Adds explicit CI and Pages closure identity steps so workflow runs expose the same correlation surface as local validation.

Issue #164 / Repo-Star Replay Context

  • Follows the final repo-star replay recommendation promoted by briancl2/build-meta-analysis#589 for Issue #164.
  • Targets the CustomerNewsletter AS-34 field signal from the final advisor package: CustomerNewsletter:Makefile, .github/workflows/ci.yml, .github/workflows/pages.yml.
  • This is an owner-surface PR; it does not mutate BMA, create controllers, install automation, or change newsletter generation behavior.

Refs briancl2/build-meta-analysis#164
Refs briancl2/build-meta-analysis#589

Validation

  • make test-closure-identity
  • python3 /Users/briancl/repos/repo-auditor/scripts/as_signature_scan.py AS-34 /Users/briancl/repos/CustomerNewsletter -> fired=false, closure_run_identity_gap_count=0
  • python3 -m py_compile tools/emit_closure_identity.py
  • git diff --check
  • make check -> 33 required suites passed, 20 private-fixture suites skipped
  • make review -> No findings

Bounded Non-Claims

  • Does not add a scheduler, queue, daemon, retry loop, background sync, hidden registry, or auto-apply behavior.
  • Does not claim every remaining repo-star field signal is fixed.
  • Does not change production newsletter content or publishing behavior.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c969c6786

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Makefile
Comment on lines 7 to +8
check: ## Run the full repo validation battery
@$(MAKE) --no-print-directory closure-identity CLOSURE_PHASE=check CLOSURE_PARENT_COMMAND="make check"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Record the required HIGR documentation

AGENTS.md requires every change to complete the Document step by updating HYPOTHESES.md, LEARNINGS.md, and HANDOFF.md; this change adds a new closure identity surface and validation target without updating those ledgers. Without that hypothesis/validation/handoff record, the new workflow behavior cannot be traced through the repo’s required HIGR process.

Useful? React with 👍 / 👎.

@briancl2
briancl2 merged commit 14287fc into main Jun 9, 2026
1 check passed
@briancl2
briancl2 deleted the codex/issue164-customernewsletter-closure-identity branch June 9, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant