feat(migration): source the migration tarball from the update manifest (stable→beta→unstable)#517
Open
mrosseel wants to merge 1 commit into
Open
feat(migration): source the migration tarball from the update manifest (stable→beta→unstable)#517mrosseel wants to merge 1 commit into
mrosseel wants to merge 1 commit into
Conversation
…t (stable→beta→unstable)
Collaborator
Author
|
Added |
e45752c to
b9a68f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded migration tarball URL with a lookup in the update manifest, so migration follows releases automatically instead of a pinned
v3.0.0-migrationURL.What changed
_migration_version_info_from_manifest(): fetchesupdate-manifest.json(brickbotsnixos-manifest), walks channels stable → beta → unstable, and returnsversion_info(version,type,migration_url,migration_sha256_url) for the first available entry that carries a migration tarball. Skips unavailable entries and entries without a tarball._MIGRATION_VERSION_INFO); shows "No release found" if the manifest has none.nixos_for_everyone(unchanged rollout control), but the tarball now comes from the manifest rather than the gate'snixos_url._fetch_migration_config()no longer requiresnixos_url— it only carries the gate flag._MIGRATION_VERSION_INFO.Depends on the manifest carrying
migration_url/migration_sha256_url, added by the release workflow in #516.Tests
TestFetchUpdateManifest+TestMigrationVersionInfoFromManifest(channel priority, beta/unstable fallback, skip unavailable, skip entries without a tarball, network/JSON failure → None). Updated the two obsolete_fetch_migration_configurl-requirement tests.Note: the new "No release found" string needs
nox -s babelextraction before translation.🤖 Generated with Claude Code