Skip to content

Update rust version#77

Merged
kylewlacy merged 4 commits into
brioche-dev:mainfrom
jaudiger:update-rust
Nov 8, 2025
Merged

Update rust version#77
kylewlacy merged 4 commits into
brioche-dev:mainfrom
jaudiger:update-rust

Conversation

@jaudiger

@jaudiger jaudiger commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
@jaudiger jaudiger requested a review from kylewlacy November 7, 2025 08:42
@jaudiger jaudiger self-assigned this Nov 7, 2025
@jaudiger jaudiger changed the title Update rust Update rust version Nov 7, 2025
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
@jaudiger

jaudiger commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Interesting with latest Rust nightly, we're now getting a build error:

error: panic_immediate_abort is now a real panic strategy! Enable it with `panic = "immediate-abort"` in Cargo.toml, or with the compiler flags `-Zunstable-options -Cpanic=immediate-abort`. In both cases, you still need to build core, e.g. with `-Zbuild-std`
  --> /home/runner/.rustup/toolchains/nightly-2025-11-01-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:36:1
   |
36 | / compile_error!(
37 | |     "panic_immediate_abort is now a real panic strategy! \
38 | |     Enable it with `panic = \"immediate-abort\"` in Cargo.toml, \
39 | |     or with the compiler flags `-Zunstable-options -Cpanic=immediate-abort`. \
40 | |     In both cases, you still need to build core, e.g. with `-Zbuild-std`"
41 | | );
   | |_^

For more information, see the Rust issue tracking immediate-abort flag. Since I don't want to support both way to do it as Microsoft did here. I'll rollback nightly before this PR was merged. And we'll wait Rust 1.92 to properly solve it (if something is required on our side).

Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>

@kylewlacy kylewlacy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Well, glad immediate-abort is going to be stabilized soon!

@kylewlacy kylewlacy merged commit aab47a6 into brioche-dev:main Nov 8, 2025
10 checks passed
@jaudiger jaudiger deleted the update-rust branch November 8, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants