Replace ConvertUTF with uchar.h (mbrtoc32/c32rtomb)#95
Closed
diplfranzhoepfinger wants to merge 1 commit into
Closed
Replace ConvertUTF with uchar.h (mbrtoc32/c32rtomb)#95diplfranzhoepfinger wants to merge 1 commit into
diplfranzhoepfinger wants to merge 1 commit into
Conversation
- Remove ConvertUTF.c, ConvertUTF.h, ConvertUTF_readme.txt - Replace <wchar.h> with <uchar.h> in SI_CONVERT_GENERIC block - Replace <stdio.h> with <cstdio> - Rewrite UTF-8 conversion using mbrtoc32/c32rtomb from <uchar.h> - Remove ConvertUTF.c from test build Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
Owner
|
I liked your idea, but there is an issue with using mbrtoc32 which is that it won't work on mac and it won't work if it isn't a utf8 locale. Instead I just did a reimplementation inline of utf8 conversion. Landed it with #97 Thanks for your prompting to make it happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com