Light mode: use the brand pink (#E0589A) as the accent#8
Closed
btravers wants to merge 1 commit into
Closed
Conversation
Per design choice, light --text-accent matches the dark-mode brand pink instead of a darkened magenta — vivid and consistent across schemes. Note: ~3.3:1 on white, so it's ideal for the large display wordmark; small labels/links trade some contrast for brand fidelity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the theme design tokens so light mode uses the same brand pink accent as dark mode, making the accent color consistent across color schemes for accent-as-text uses.
Changes:
- Set light-mode
--text-accentto#E0589A(brand pink) intokens.css. - Adjust the inline comment describing expected contrast/usage implications for
--text-accentin light mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
149
to
151
| --accent: #E0589A; /* fill unchanged (dark ink on top) */ | ||
| --text-accent: #C42A6C; /* punchier vivid beetroot, ~5.1:1 on white (was #A52260) */ | ||
| --text-accent: #E0589A; /* brand pink in light too (brand choice) — vivid; ~3.3:1, great for the display wordmark, low-contrast on small labels */ | ||
| --text-green: #15683A; /* ~5.2:1 on white — affirmative text */ |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7 (which merged with
#C42A6C). Per the picked option, the light-mode accent now matches the dark-mode brand pink#E0589Ainstead of a darkened magenta — vivid and consistent across schemes.Single-line change:
tokens.csslight--text-accent→#E0589A. Drives the wordmark, eyebrows, tags, and docs links in light mode; fills are unchanged.Contrast note:
#E0589Ais ~3.3:1 on white — ideal for the large display wordmark, below WCAG-AA for small labels/links (an accepted brand trade-off). Verified: light wordmark resolvesrgb(224,88,154); lockfile unchanged; build green.